-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allow passing extra table options #3484
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3484 +/- ##
==========================================
- Coverage 85.42% 85.01% -0.41%
==========================================
Files 898 899 +1
Lines 148395 148476 +81
==========================================
- Hits 126768 126233 -535
- Misses 21627 22243 +616 |
dc3f592
to
c139b81
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
fixes #3476
What's changed and what's your intention?
This PR removes the validation for table options in the create parser as different engine might require different extra options.
Now we can specify engine related options via
with
statement. The following statement sets compaction time window to 1 day.Note that
compaction.type
is required if we want to set compaction options.Checklist