-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support decode gzip if influxdb write specify it #3494
Conversation
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3494 +/- ##
==========================================
- Coverage 85.33% 84.92% -0.41%
==========================================
Files 903 904 +1
Lines 149873 150172 +299
==========================================
- Hits 127887 127538 -349
- Misses 21986 22634 +648 |
No. tower's version is another issue. @killme2008 I suppose we move the better middleware layer impl a follow-up. It seems much more complex and involves a few deps version issue. |
Signed-off-by: tison <wander4096@gmail.com>
Finally get it work with: .layer(
ServiceBuilder::new()
.layer(HandleErrorLayer::new(handle_error))
.layer(RequestDecompressionLayer::new()),
) PTAL @killme2008 @shuiyisong |
Signed-off-by: tison <wander4096@gmail.com>
However, the existing middleware doesn't handle case for header value (That is, if the client use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
This closes #3487.
What's changed and what's your intention?
Tested locally. But I'd appreciate it if you can tell me how to add a test coverage in CI ...
Checklist