-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(fuzz): add alter table target #3503
Conversation
2bb2c24
to
aad4ff0
Compare
aad4ff0
to
84b1c49
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3503 +/- ##
==========================================
- Coverage 85.32% 84.92% -0.40%
==========================================
Files 904 904
Lines 149972 150172 +200
==========================================
- Hits 127962 127537 -425
- Misses 22010 22635 +625 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
let index = self | ||
.columns | ||
.iter() | ||
// TODO(weny): find a better way? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@WenyXu why do you think this impl is suboptimal? It literally implement the semantic and since total columns should be in a small set I think it's good to do:
fn position<P>(&mut self, mut predicate: P) -> Option<usize> where ...
{
let n = len!(self);
let mut i = 0;
while let Some(x) = self.next() {
if predicate(x) {
return Some(i);
}
i += 1;
}
None
}
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
#3174
What's changed and what's your intention?
add alter table target
Checklist