Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fuzz): add alter table target #3503

Merged
merged 4 commits into from
Mar 13, 2024

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Mar 13, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

#3174

What's changed and what's your intention?

add alter table target

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Mar 13, 2024
@WenyXu WenyXu force-pushed the feat/fuzz-test-alter branch from 2bb2c24 to aad4ff0 Compare March 13, 2024 11:05
@WenyXu WenyXu force-pushed the feat/fuzz-test-alter branch from aad4ff0 to 84b1c49 Compare March 13, 2024 11:10
@WenyXu WenyXu marked this pull request as draft March 13, 2024 11:14
@WenyXu WenyXu marked this pull request as ready for review March 13, 2024 11:18
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 78.46890% with 45 lines in your changes are missing coverage. Please review.

Project coverage is 84.92%. Comparing base (b55905c) to head (eab40ad).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3503      +/-   ##
==========================================
- Coverage   85.32%   84.92%   -0.40%     
==========================================
  Files         904      904              
  Lines      149972   150172     +200     
==========================================
- Hits       127962   127537     -425     
- Misses      22010    22635     +625     

Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waynexia waynexia added this pull request to the merge queue Mar 13, 2024
Merged via the queue into GreptimeTeam:main with commit e433396 Mar 13, 2024
20 checks passed
let index = self
.columns
.iter()
// TODO(weny): find a better way?
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WenyXu why do you think this impl is suboptimal? It literally implement the semantic and since total columns should be in a small set I think it's good to do:

fn position<P>(&mut self, mut predicate: P) -> Option<usize> where ...
{
                let n = len!(self);
                let mut i = 0;
                while let Some(x) = self.next() {
                    if predicate(x) {
                        return Some(i);
                    }
                    i += 1;
                }
                None
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants