Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement the drop database parser #3521

Merged
merged 5 commits into from
Mar 15, 2024

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Mar 14, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Implement the drop database parser

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Mar 14, 2024
@WenyXu WenyXu force-pushed the feat/drop-database-parser branch from 877d2c3 to 51b7825 Compare March 14, 2024 12:42
@WenyXu WenyXu force-pushed the feat/drop-database-parser branch from 51b7825 to b14599f Compare March 14, 2024 12:49
src/operator/src/statement.rs Outdated Show resolved Hide resolved
Co-authored-by: Ruihang Xia <waynestxia@gmail.com>
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 84.96%. Comparing base (5ad3b79) to head (450bf85).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3521      +/-   ##
==========================================
- Coverage   85.31%   84.96%   -0.35%     
==========================================
  Files         904      905       +1     
  Lines      150248   150828     +580     
==========================================
- Hits       128178   128147      -31     
- Misses      22070    22681     +611     

@MichaelScofield MichaelScofield added this pull request to the merge queue Mar 15, 2024
Merged via the queue into GreptimeTeam:main with commit a52aede Mar 15, 2024
18 checks passed
@WenyXu WenyXu mentioned this pull request Mar 19, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants