-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(metasrv): implement maintenance #3527
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Co-authored-by: Yingwen <realevenyag@gmail.com> Co-authored-by: xifyang <595482900@qq.com>
github-actions
bot
added
docs-not-required
This change does not impact docs.
Invalid PR Title
labels
Mar 16, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3527 +/- ##
==========================================
- Coverage 85.35% 84.94% -0.42%
==========================================
Files 906 907 +1
Lines 151023 151143 +120
==========================================
- Hits 128913 128391 -522
- Misses 22110 22752 +642 |
MichaelScofield
approved these changes
Mar 18, 2024
Co-authored-by: LFC <990479+MichaelScofield@users.noreply.github.com>
WenyXu
reviewed
Mar 18, 2024
Signed-off-by: tison <wander4096@gmail.com>
WenyXu
approved these changes
Mar 18, 2024
MichaelScofield
added
docs-required
This change requires docs update.
and removed
docs-not-required
This change does not impact docs.
labels
Mar 18, 2024
github-actions
bot
added
docs-not-required
This change does not impact docs.
and removed
docs-required
This change requires docs update.
labels
Mar 18, 2024
Need a doc. |
github-actions
bot
added
docs-required
This change requires docs update.
and removed
docs-not-required
This change does not impact docs.
labels
Mar 18, 2024
fengjiachun
approved these changes
Mar 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This was referenced Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
Add "/maintenance" and "/maintenance/set" endpoint on metasrv admin APIs.
Skip failure failed_regions handling if
is_maintenance_mode
.cc @xifyang
Checklist