Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metasrv): implement maintenance #3527

Merged
merged 6 commits into from
Mar 18, 2024

Conversation

tisonkun
Copy link
Collaborator

@tisonkun tisonkun commented Mar 16, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Add "/maintenance" and "/maintenance/set" endpoint on metasrv admin APIs.

Skip failure failed_regions handling if is_maintenance_mode.

cc @xifyang

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

tisonkun and others added 3 commits March 16, 2024 11:58
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Co-authored-by: Yingwen <realevenyag@gmail.com>
Co-authored-by: xifyang <595482900@qq.com>
@tisonkun tisonkun changed the title Maintenance feat(metasrv): implement maintenance Mar 16, 2024
@github-actions github-actions bot added docs-not-required This change does not impact docs. Invalid PR Title labels Mar 16, 2024
Signed-off-by: tison <wander4096@gmail.com>
Copy link

codecov bot commented Mar 16, 2024

Codecov Report

Attention: Patch coverage is 45.20548% with 80 lines in your changes are missing coverage. Please review.

Project coverage is 84.94%. Comparing base (74862f8) to head (7b407fc).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3527      +/-   ##
==========================================
- Coverage   85.35%   84.94%   -0.42%     
==========================================
  Files         906      907       +1     
  Lines      151023   151143     +120     
==========================================
- Hits       128913   128391     -522     
- Misses      22110    22752     +642     

src/meta-srv/src/handler/failure_handler/runner.rs Outdated Show resolved Hide resolved
src/meta-srv/src/service/admin/maintenance.rs Outdated Show resolved Hide resolved
Co-authored-by: LFC <990479+MichaelScofield@users.noreply.github.com>
src/meta-srv/src/metasrv.rs Outdated Show resolved Hide resolved
Signed-off-by: tison <wander4096@gmail.com>
@MichaelScofield MichaelScofield added docs-required This change requires docs update. and removed docs-not-required This change does not impact docs. labels Mar 18, 2024
@MichaelScofield MichaelScofield added this pull request to the merge queue Mar 18, 2024
@github-actions github-actions bot added docs-not-required This change does not impact docs. and removed docs-required This change requires docs update. labels Mar 18, 2024
@MichaelScofield
Copy link
Collaborator

Need a doc.

@github-actions github-actions bot added docs-required This change requires docs update. and removed docs-not-required This change does not impact docs. labels Mar 18, 2024
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Merged via the queue into GreptimeTeam:main with commit 0afac58 Mar 18, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-required This change requires docs update.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "maintenance mode" for region failover in Metasrv.
4 participants