Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update pgwire to 0.20 for improved performance #3538

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

sunng87
Copy link
Member

@sunng87 sunng87 commented Mar 18, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

This patch upgrades pgwire to latest 0.20 for improvement of writing resultset to client.

Content of this patch are mostly API change adoption. What actually improves performance for writing data rows are in sunng87/pgwire#165 and sunng87/pgwire#166

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Mar 18, 2024
@sunng87 sunng87 requested review from waynexia and shuiyisong March 18, 2024 21:08
Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waynexia waynexia enabled auto-merge March 19, 2024 03:04
Copy link
Contributor

@shuiyisong shuiyisong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FGTM

@waynexia waynexia added this pull request to the merge queue Mar 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 19, 2024
@MichaelScofield MichaelScofield added this pull request to the merge queue Mar 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 19, 2024
@tisonkun tisonkun added this pull request to the merge queue Mar 19, 2024
Merged via the queue into GreptimeTeam:main with commit a99d6eb Mar 19, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants