Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refactor CacheInvalidator #3550

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Mar 20, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

#3516
fix #2369

What's changed and what's your intention?

Use the InvalidateCaches instruction instead of InvalidateTableId and InvalidateTableName To avoid some cache inconsistency issues.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Mar 20, 2024
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 97.01493% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 84.98%. Comparing base (bbcdb28) to head (868ebe8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3550      +/-   ##
==========================================
- Coverage   85.35%   84.98%   -0.37%     
==========================================
  Files         910      910              
  Lines      152030   152031       +1     
==========================================
- Hits       129769   129211     -558     
- Misses      22261    22820     +559     

Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaelScofield MichaelScofield added this pull request to the merge queue Mar 20, 2024
Merged via the queue into GreptimeTeam:main with commit 856a4e1 Mar 20, 2024
18 checks passed
@WenyXu WenyXu mentioned this pull request Mar 20, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalidate keys cache using an atomic operation
3 participants