fix(flow): Arrange get range with batch unaligned #3552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3552 +/- ##
==========================================
- Coverage 85.37% 85.00% -0.37%
==========================================
Files 910 910
Lines 152034 152225 +191
==========================================
- Hits 129792 129399 -393
- Misses 22242 22826 +584 |
zhongzc
reviewed
Mar 20, 2024
zhongzc
reviewed
Mar 20, 2024
|
rest LGTM |
zhongzc
approved these changes
Mar 20, 2024
waynexia
reviewed
Mar 23, 2024
Comment on lines
+28
to
+29
| pub type Batch = BTreeMap<Row, SmallVec<[DiffRow; 2]>>; | ||
| pub type Spine = BTreeMap<Timestamp, Batch>; |
There was a problem hiding this comment.
👍
Maybe also move/duplicate some document to those alias
Comment on lines
+201
to
+203
| } else { | ||
| continue; | ||
| } |
There was a problem hiding this comment.
nit: unnecessary continue?
Suggested change
| } else { | |
| continue; | |
| } | |
| } |
|
Forget to send them... |
19 tasks
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
Fix arrangement's batches's interaction with get by range unaligned with batch boundaries. Related tests are added and commented in details.
Checklist