Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: performance degradation caused by config change #3556

Merged
merged 1 commit into from
Mar 21, 2024
Merged

fix: performance degradation caused by config change #3556

merged 1 commit into from
Mar 21, 2024

Conversation

v0y4g3r
Copy link
Contributor

@v0y4g3r v0y4g3r commented Mar 21, 2024 •
edited
Loading

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Change the default fork_dictionary_bytes config in PartitionTreeMemtable to mitigate performance issue.

Ingestion rate
image

Memory usage
image

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Mar 21, 2024
@v0y4g3r v0y4g3r marked this pull request as ready for review March 21, 2024 08:35
@v0y4g3r v0y4g3r requested review from evenyag and waynexia March 21, 2024 08:35
@codecov Codecov
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 84.99%. Comparing base (8b7a5aa) to head (e9781b0).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3556      +/-   ##
==========================================
- Coverage   85.37%   84.99%   -0.38%     
==========================================
  Files         910      910              
  Lines      152023   152033      +10     
==========================================
- Hits       129783   129221     -562     
- Misses      22240    22812     +572

waynexia
waynexia approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This patch looks good to me 👍

(But I have to 😵 for PartitionTreeOptions and PartitionTreeConfig...

evenyag
evenyag approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad......

@evenyag evenyag added this pull request to the merge queue Mar 21, 2024
Merged via the queue into GreptimeTeam:main with commit 1f0fc40 Mar 21, 2024
24 of 35 checks passed
MichaelScofield pushed a commit to MichaelScofield/greptimedb that referenced this pull request Mar 22, 2024
@v0y4g3r @MichaelScofield
fix: performance degradation caused by config change (GreptimeTeam#3556)
ba3313a
@tisonkun tisonkun mentioned this pull request Apr 9, 2024
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waynexia waynexia waynexia approved these changes

@evenyag evenyag evenyag approved these changes

Assignees
No one assigned
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Metric engine ingestion performance degradation
3 participants
@v0y4g3r @evenyag @waynexia