Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add a parameter type mismatch test case to sql integration test #3568

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

xxxuuu
Copy link
Contributor

@xxxuuu xxxuuu commented Mar 22, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

This closes #2920

What's changed and what's your intention?

As the title says

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Mar 22, 2024
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.02%. Comparing base (1f0fc40) to head (21c79c0).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3568      +/-   ##
==========================================
- Coverage   85.36%   85.02%   -0.35%     
==========================================
  Files         910      910              
  Lines      152033   152193     +160     
==========================================
- Hits       129784   129395     -389     
- Misses      22249    22798     +549     

Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Welcome to the GreptimeDB community!

Copy link
Collaborator

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

LGTM. I'll update the PR description to associatedly close the issue.

And welcome :D

@tisonkun tisonkun added this pull request to the merge queue Mar 22, 2024
Merged via the queue into GreptimeTeam:main with commit 24886b9 Mar 22, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a test for parameter type mismatch
3 participants