-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: batch alter logical tables #3569
Merged
fengjiachun
merged 6 commits into
GreptimeTeam:main
from
fengjiachun:feat/alter-logical-tables
Mar 26, 2024
Merged
feat: batch alter logical tables #3569
fengjiachun
merged 6 commits into
GreptimeTeam:main
from
fengjiachun:feat/alter-logical-tables
Mar 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengjiachun
force-pushed
the
feat/alter-logical-tables
branch
2 times, most recently
from
March 24, 2024 09:54
6428f0c
to
38c70a7
Compare
fengjiachun
force-pushed
the
feat/alter-logical-tables
branch
2 times, most recently
from
March 24, 2024 13:51
4550b6a
to
6f1876b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3569 +/- ##
==========================================
- Coverage 85.25% 84.84% -0.41%
==========================================
Files 917 924 +7
Lines 152869 153487 +618
==========================================
- Hits 130324 130231 -93
- Misses 22545 23256 +711 |
After #3570 |
fengjiachun
force-pushed
the
feat/alter-logical-tables
branch
2 times, most recently
from
March 25, 2024 13:07
1c2fd3c
to
1d5b7b6
Compare
fengjiachun
force-pushed
the
feat/alter-logical-tables
branch
from
March 25, 2024 13:18
1d5b7b6
to
077d27e
Compare
waynexia
reviewed
Mar 26, 2024
WenyXu
reviewed
Mar 26, 2024
Co-authored-by: Ruihang Xia <waynestxia@gmail.com>
fengjiachun
force-pushed
the
feat/alter-logical-tables
branch
from
March 26, 2024 06:01
ee9c249
to
ca5fc39
Compare
waynexia
approved these changes
Mar 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
WenyXu
approved these changes
Mar 26, 2024
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
As the title said
Checklist