Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add tests for drop databases #3594

Merged
merged 5 commits into from
Mar 27, 2024

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Mar 27, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

#3516

What's changed and what's your intention?

add tests for drop databases

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

WenyXu added 3 commits March 27, 2024 06:48

Verified

This commit was signed with the committer’s verified signature.
WenyXu Weny Xu

Verified

This commit was signed with the committer’s verified signature.
WenyXu Weny Xu

Verified

This commit was signed with the committer’s verified signature.
WenyXu Weny Xu
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Mar 27, 2024
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 95.78059% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 84.94%. Comparing base (623c930) to head (e9df15d).

❗ Current head e9df15d differs from pull request most recent head e4c21d7. Consider uploading reports for the commit e4c21d7 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3594      +/-   ##
==========================================
- Coverage   85.20%   84.94%   -0.26%     
==========================================
  Files         930      931       +1     
  Lines      154235   154702     +467     
==========================================
- Hits       131422   131418       -4     
- Misses      22813    23284     +471     

Verified

This commit was signed with the committer’s verified signature.
WenyXu Weny Xu
@WenyXu WenyXu force-pushed the test/drop-database branch from dc1885a to e9df15d Compare March 27, 2024 08:47

Verified

This commit was signed with the committer’s verified signature.
WenyXu Weny Xu
@WenyXu WenyXu mentioned this pull request Mar 27, 2024
9 tasks
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengjiachun fengjiachun enabled auto-merge March 27, 2024 09:11
@fengjiachun fengjiachun added this pull request to the merge queue Mar 27, 2024
Merged via the queue into GreptimeTeam:main with commit 5addb7d Mar 27, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants