Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: do not reply for broadcast msg #3595

Conversation

fengjiachun
Copy link
Collaborator

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

It is unnecessary to reply to the broadcast msg from metasrv

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Mar 27, 2024
@fengjiachun fengjiachun force-pushed the chore/do-not-reply-broadcast-msg branch from ebafd77 to a35b8f5 Compare March 27, 2024 11:25
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 85.01%. Comparing base (5addb7d) to head (a35b8f5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3595      +/-   ##
==========================================
- Coverage   85.36%   85.01%   -0.36%     
==========================================
  Files         931      931              
  Lines      154702   154611      -91     
==========================================
- Hits       132065   131444     -621     
- Misses      22637    23167     +530     

@MichaelScofield MichaelScofield added this pull request to the merge queue Mar 27, 2024
Merged via the queue into GreptimeTeam:main with commit 92a8e86 Mar 27, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants