-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement an unordered scanner for append mode #3598
Conversation
16c2f8f
to
09f5761
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
09f5761
to
7760a96
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3598 +/- ##
==========================================
- Coverage 85.40% 85.06% -0.34%
==========================================
Files 931 932 +1
Lines 154826 155045 +219
==========================================
- Hits 132224 131894 -330
- Misses 22602 23151 +549 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
This PR implements a new scanner for append only regions.
ScanInput
struct to keep fields required to build a scannerUnorderedScan
to scan all sourcesUnorderedScan
is unspecificscan_parallelism > 1
, it scans sources in parallelUnorderedScan
andSeqScan
useScanInput
to construct sourcesUnorderedScan
for query if it is append only (append_mode = true
)SeqScan
ifappend_mode = false
SeqScan
Checklist