Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: run purge jobs in another scheduler #3621

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

evenyag
Copy link
Contributor

@evenyag evenyag commented Mar 31, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

This PR creates a new scheduler for purge jobs instead of reusing the global scheduler. It avoids purge jobs blocking other background jobs, especially flush jobs.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Mar 31, 2024
@evenyag evenyag marked this pull request as ready for review March 31, 2024 06:24
@evenyag evenyag requested review from v0y4g3r and shuiyisong March 31, 2024 06:26
Copy link

codecov bot commented Mar 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.03%. Comparing base (4a5bb69) to head (e5ca70c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3621      +/-   ##
==========================================
- Coverage   85.38%   85.03%   -0.36%     
==========================================
  Files         932      932              
  Lines      155596   155605       +9     
==========================================
- Hits       132857   132319     -538     
- Misses      22739    23286     +547     

Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@v0y4g3r v0y4g3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@v0y4g3r v0y4g3r added this pull request to the merge queue Apr 1, 2024
Merged via the queue into GreptimeTeam:main with commit bfd3257 Apr 1, 2024
21 of 32 checks passed
@v0y4g3r v0y4g3r deleted the fix/purge-scheduler branch April 1, 2024 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants