-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: reject invalid timestamp ranges in copy statement #3623
feat: reject invalid timestamp ranges in copy statement #3623
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3623 +/- ##
==========================================
- Coverage 85.35% 85.02% -0.33%
==========================================
Files 932 932
Lines 155611 155620 +9
==========================================
- Hits 132818 132313 -505
- Misses 22793 23307 +514 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this prompt fix.
- This patch should be "fix" or "feat" rather than "chore".
- Perhaps we can lower the Option -> Result into
GenericRange::new
method? All other refs seems in the test scope.
Fixed.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your updates and explanation! LGTM.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
This PR adds timestamp validity check to reject invalid timestamps in
copy
statement.Checklist