Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add append mode to table options #3624

Merged
merged 4 commits into from
Apr 8, 2024

Conversation

evenyag
Copy link
Contributor

@evenyag evenyag commented Apr 1, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

This PR adds append_mode to mito engine's table options. It also adds a sqlness test for append mode.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@evenyag evenyag force-pushed the feat/table-append-option branch from 72b3e78 to e2045dc Compare April 2, 2024 06:21
@evenyag evenyag marked this pull request as ready for review April 2, 2024 06:21
@evenyag evenyag requested review from fengjiachun and v0y4g3r April 2, 2024 06:22
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 85.04%. Comparing base (6c316d2) to head (e2045dc).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3624      +/-   ##
==========================================
- Coverage   85.36%   85.04%   -0.32%     
==========================================
  Files         935      935              
  Lines      156348   156350       +2     
==========================================
- Hits       133463   132973     -490     
- Misses      22885    23377     +492     

Copy link
Contributor

@v0y4g3r v0y4g3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evenyag evenyag mentioned this pull request Apr 8, 2024
4 tasks
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengjiachun fengjiachun added this pull request to the merge queue Apr 8, 2024
Merged via the queue into GreptimeTeam:main with commit 3e1a125 Apr 8, 2024
21 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-required This change requires docs update.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants