refactor: drop Table trait #3654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tisonkun
commented
Apr 7, 2024
Signed-off-by: tison <wander4096@gmail.com>
tisonkun
force-pushed
the
remove-table-trait
branch
from
8e34139 to
c34f9eb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3654 +/- ##
==========================================
- Coverage 85.14% 84.82% -0.33%
==========================================
Files 943 942 -1
Lines 157092 157092
==========================================
- Hits 133754 133250 -504
- Misses 23338 23842 +504 |
Signed-off-by: tison <wander4096@gmail.com>
zhongzc
reviewed
Apr 7, 2024
zhongzc
reviewed
Apr 7, 2024
Co-authored-by: Zhenchi <zhongzc_arch@outlook.com>
zhongzc
reviewed
Apr 7, 2024
zhongzc
reviewed
Apr 7, 2024
zhongzc
approved these changes
Apr 7, 2024
Signed-off-by: tison <wander4096@gmail.com>
|
All handled. |
zhongzc
approved these changes
Apr 7, 2024
waynexia
approved these changes
Apr 8, 2024
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
This refers to #2065.
Checklist