Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: impl show collation and show charset statements #3753

Merged
merged 2 commits into from
Apr 20, 2024

Conversation

killme2008
Copy link
Contributor

@killme2008 killme2008 commented Apr 19, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

#3354

Please explain IN DETAIL what the changes are in this PR and why they are needed:

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@killme2008 killme2008 marked this pull request as ready for review April 19, 2024 13:46
@killme2008 killme2008 requested review from evenyag and a team as code owners April 19, 2024 13:46
@github-actions github-actions bot added the docs-required This change requires docs update. label Apr 19, 2024
@killme2008 killme2008 requested review from tisonkun and shuiyisong and removed request for evenyag April 19, 2024 13:47
Copy link

codecov bot commented Apr 19, 2024

Codecov Report

Attention: Patch coverage is 52.20126% with 76 lines in your changes are missing coverage. Please review.

Project coverage is 85.21%. Comparing base (d077892) to head (1f7da6a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3753      +/-   ##
==========================================
- Coverage   85.57%   85.21%   -0.37%     
==========================================
  Files         945      945              
  Lines      159259   159357      +98     
==========================================
- Hits       136280   135790     -490     
- Misses      22979    23567     +588     

@tisonkun tisonkun added this pull request to the merge queue Apr 20, 2024
Merged via the queue into GreptimeTeam:main with commit 8f2ce4a Apr 20, 2024
19 checks passed
@killme2008 killme2008 deleted the feature/show-collations branch April 20, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-required This change requires docs update.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants