-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: replace anymap with anymap2 #4781
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
@zyy17 @shuiyisong Please let me know if there're any downstream projects that may be affected by this change and I will fix them as soon as this get's merged. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4781 +/- ##
==========================================
- Coverage 84.47% 84.21% -0.26%
==========================================
Files 1118 1118
Lines 203093 203093
==========================================
- Hits 171560 171034 -526
- Misses 31533 32059 +526 |
It's strange that anymap2 doesn't seem to be under maintenance either. |
I don't think simple crates like |
Or we can maintain the |
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
This PR replaces the
anymap
dependency in plugin crate withanymap2
in that the recent toolchain gives a warning:Related issues:
ptr_cast_add_auto_to_object
rust-lang/rust#127323Looks like
anymap
is no longer under maintainence, we should switch to anymap2.Checklist