-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Limit CPU in runtime (#3685) #4782
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
46991de
to
e23f85e
Compare
@fengys1996 Please also take a look at this PR, aiming to provide a new relaxed runtime to constrain CPU usage of spawned tasks. |
6e98474
to
ba4ede3
Compare
51d91b0
to
8c5054e
Compare
It looks like there are some conflicts and some compilation errors. Please resolve them first. |
b659487
to
c60462c
Compare
bce877e
to
9ff081f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have a document to describe how this runtime works and how to find a proper priority for the runtime? I'd suggest providing more docs in the runtime crate.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4782 +/- ##
==========================================
- Coverage 84.24% 83.92% -0.32%
==========================================
Files 1131 1134 +3
Lines 208879 209212 +333
==========================================
- Hits 175976 175591 -385
- Misses 32903 33621 +718 |
369dc24
to
10c9a21
Compare
8ecf99e
to
c37ee8d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. There are some remaining enhancements we can acheive in other PRs. e.g. Making tokens of different priorities configurable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@fengys1996 I think we can test this feature on the new version of GreptimeDB edge now to see if it can manage the total CPU usage. |
Great work! Thanks a lot. |
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
#3685
What's changed and what's your intention?
parking_lot.workspace = true
in sub project.Checklist