Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: information extension #4811

Merged
merged 3 commits into from
Oct 11, 2024
Merged

feat: information extension #4811

merged 3 commits into from
Oct 11, 2024

Conversation

fengjiachun
Copy link
Collaborator

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Introduce InformationExtension trait to provide extension queries for information schema. Currently, the methods provided are nodes, procedures, and region_stats.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@fengjiachun fengjiachun requested a review from a team as a code owner October 10, 2024 09:45
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Oct 10, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 10, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 13.29480% with 150 lines in your changes missing coverage. Please review.

Project coverage is 84.17%. Comparing base (a8ed3db) to head (ee0f2ad).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4811      +/-   ##
==========================================
- Coverage   84.42%   84.17%   -0.26%     
==========================================
  Files        1124     1125       +1     
  Lines      204759   204865     +106     
==========================================
- Hits       172873   172438     -435     
- Misses      31886    32427     +541

WenyXu
WenyXu approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@WenyXu WenyXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/catalog/src/kvbackend/manager.rs Outdated Show resolved Hide resolved
@fengjiachun @WenyXu
Update manager.rs
cf6bb25 
Co-authored-by: Weny Xu <wenymedia@gmail.com>
MichaelScofield
MichaelScofield approved these changes Oct 11, 2024
View reviewed changes
src/catalog/src/system_schema/utils.rs Outdated Show resolved Hide resolved
@fengjiachun fengjiachun added this pull request to the merge queue Oct 11, 2024
Merged via the queue into GreptimeTeam:main with commit 4b34f61 Oct 11, 2024
33 checks passed
@fengjiachun fengjiachun deleted the feat/information-extension branch October 11, 2024 03:33
@fengjiachun fengjiachun mentioned this pull request Oct 11, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WenyXu WenyXu WenyXu approved these changes

@MichaelScofield MichaelScofield MichaelScofield approved these changes

Assignees
No one assigned
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fengjiachun @MichaelScofield @WenyXu