Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable prof features by default #4815

Merged
merged 5 commits into from
Oct 14, 2024

Conversation

evenyag
Copy link
Contributor

@evenyag evenyag commented Oct 11, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

This PR enables prof features by default. We already move prof APIs to behind /debug URL and don't expose them as part of public v1 API, so it should be safe to enable them by default.

We can revert this if there are other issues.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Oct 11, 2024
@evenyag evenyag marked this pull request as ready for review October 11, 2024 07:16
@evenyag evenyag requested a review from a team as a code owner October 11, 2024 07:16
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 45 lines in your changes missing coverage. Please review.

Project coverage is 84.16%. Comparing base (d168bde) to head (6983fb5).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4815      +/-   ##
==========================================
- Coverage   84.43%   84.16%   -0.27%     
==========================================
  Files        1125     1124       -1     
  Lines      204866   204891      +25     
==========================================
- Hits       172970   172449     -521     
- Misses      31896    32442     +546     

@discord9
Copy link
Contributor

CI says it can't compile on windows, maybe cfg gate windows for pprof?

@evenyag
Copy link
Contributor Author

evenyag commented Oct 13, 2024

CI says it can't compile on windows, maybe cfg gate windows for pprof?

@discord9 I added a new crate and used the cfg gate to import pprof on Linux/macOS.

@evenyag evenyag added this pull request to the merge queue Oct 14, 2024
Merged via the queue into GreptimeTeam:main with commit 3b2ce31 Oct 14, 2024
41 checks passed
@evenyag evenyag deleted the feat/default-enable-prof branch October 14, 2024 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants