-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable prof features by default #4815
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4815 +/- ##
==========================================
- Coverage 84.43% 84.16% -0.27%
==========================================
Files 1125 1124 -1
Lines 204866 204891 +25
==========================================
- Hits 172970 172449 -521
- Misses 31896 32442 +546 |
CI says it can't compile on windows, maybe cfg gate windows for pprof? |
@discord9 I added a new crate and used the cfg gate to import pprof on Linux/macOS. |
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
This PR enables prof features by default. We already move prof APIs to behind
/debug
URL and don't expose them as part of public v1 API, so it should be safe to enable them by default.We can revert this if there are other issues.
Checklist