Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce LeadershipChangeNotifier and LeadershipChangeListener #4817

Merged
merged 5 commits into from
Oct 11, 2024

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Oct 11, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Introduce LeadershipChangeNotifier and LeadershipChangeListener, allowing the upper layer to register listeners to react to leadership change events.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Oct 11, 2024
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 51.90840% with 63 lines in your changes missing coverage. Please review.

Project coverage is 84.15%. Comparing base (d168bde) to head (3e4b8d5).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4817      +/-   ##
==========================================
- Coverage   84.43%   84.15%   -0.28%     
==========================================
  Files        1125     1127       +2     
  Lines      204866   204980     +114     
==========================================
- Hits       172970   172505     -465     
- Misses      31896    32475     +579     

@WenyXu WenyXu enabled auto-merge October 11, 2024 11:39
Copy link
Contributor

@discord9 discord9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WenyXu WenyXu added this pull request to the merge queue Oct 11, 2024
Merged via the queue into GreptimeTeam:main with commit 4bb1f4f Oct 11, 2024
33 checks passed
@WenyXu WenyXu deleted the feat/leadership-change-notifier branch October 11, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants