Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: yields empty batch after reading a range #4845

Merged
merged 6 commits into from
Oct 21, 2024

Conversation

evenyag
Copy link
Contributor

@evenyag evenyag commented Oct 17, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

This PR adds an empty batch to the end of the stream for each PartitionRange.

It also adds a BatchChecker to validate batches in the scanner.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Oct 17, 2024
@evenyag evenyag marked this pull request as ready for review October 17, 2024 13:47
@evenyag evenyag requested review from v0y4g3r, waynexia and a team as code owners October 17, 2024 13:47
@evenyag evenyag mentioned this pull request Oct 17, 2024
11 tasks
@evenyag evenyag requested a review from discord9 October 17, 2024 14:17
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 60.18519% with 43 lines in your changes missing coverage. Please review.

Project coverage is 84.00%. Comparing base (e0c4157) to head (9614b53).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4845      +/-   ##
==========================================
- Coverage   84.26%   84.00%   -0.27%     
==========================================
  Files        1128     1128              
  Lines      208260   208363     +103     
==========================================
- Hits       175494   175030     -464     
- Misses      32766    33333     +567     

@waynexia waynexia added this pull request to the merge queue Oct 21, 2024
Merged via the queue into GreptimeTeam:main with commit 5d28f7a Oct 21, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants