Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: replace timeout_millis and connect_timeout_millis with Duration in DatanodeClientOptions #4867

Merged
merged 2 commits into from
Oct 23, 2024

fix: fix unit test

404a525
Select commit
Loading
Failed to load commit list.
Merged

fix!: replace timeout_millis and connect_timeout_millis with Duration in DatanodeClientOptions #4867

fix: fix unit test
404a525
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 23, 2024 in 0s

83.99% (-0.27%) compared to 6d503b0

View this Pull Request on Codecov

83.99% (-0.27%) compared to 6d503b0

Details

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.99%. Comparing base (6d503b0) to head (404a525).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4867      +/-   ##
==========================================
- Coverage   84.25%   83.99%   -0.27%     
==========================================
  Files        1129     1129              
  Lines      208474   208474              
==========================================
- Hits       175653   175101     -552     
- Misses      32821    33373     +552