-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: integration test suite #487
Conversation
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
692a5a5
to
e3564a2
Compare
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Codecov Report
@@ Coverage Diff @@
## develop #487 +/- ##
===========================================
- Coverage 86.41% 86.35% -0.06%
===========================================
Files 400 401 +1
Lines 50671 50769 +98
===========================================
+ Hits 43788 43843 +55
- Misses 6883 6926 +43
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
license-eye has totally checked 615 files.
Valid | Invalid | Ignored | Fixed |
---|---|---|---|
520 | 3 | 92 | 0 |
Click to see the invalid file list
- tests/runner/src/env.rs
- tests/runner/src/main.rs
- tests/runner/src/util.rs
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Maybe better to mention that we need to clean the data directory before runing test. |
I plan to write a document in dev-guide to describe how to run and add integration test when this gets merged. I'll mention this here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Changes Included
Add a SQL integration test suites and a group of basic SQLs from "get started" document. This test suite only supports local standalone mode now.
To run it, use
cd tests/runner cargo run
Notes
The dependency
sqlness
is not published, I'm discussing publish procedure with CeresDB authors (it is derived from there). When things done I'll update it to crates.io registry.Known problem
The start command is
cargo run -- datanode start
, which may cause zombie process when closing. It should be run from the binary directly.Due to the
DROP TABLE
clause is not supported now, tests cannot clear its state and will result to "table already exist" when re-run it.