-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: pprof #4938
fix: pprof #4938
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4938 +/- ##
==========================================
- Coverage 84.22% 83.88% -0.35%
==========================================
Files 1137 1141 +4
Lines 210098 211208 +1110
==========================================
+ Hits 176958 177164 +206
- Misses 33140 34044 +904 |
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
previous due to lack of maintaince pprof crate is not usable in certain platform.
Fork and applied a fix which check for null pointer and update ahash crate which now fix pprof for my machine.
The fork is here: https://github.com/GreptimeTeam/pprof-rs
Before this fix, my machine panic on trying to pprof, now it can get a flamegraph(The db is basically idle when doing the pprof):
Checklist