-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: alter fulltext options #4952
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
7cc1882
to
77852d1
Compare
5298fde
to
63479f6
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4952 +/- ##
==========================================
- Coverage 84.06% 83.84% -0.23%
==========================================
Files 1143 1143
Lines 212022 212512 +490
==========================================
- Hits 178242 178174 -68
- Misses 33780 34338 +558 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
Co-Authored-By: irenjj <renj.jiang@gmail.com>
Co-Authored-By: irenjj <renj.jiang@gmail.com>
Co-Authored-By: irenjj <renj.jiang@gmail.com>
d267348
to
6678fa5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
close #4395
What's changed and what's your intention?
As in #4637, support alter fulltext options for column:
ALTER TABLE monitor SET COLUMN <column_name> FULLTEXT WITH(analyzer = 'Chinese', case_sensitive = 'false');
Currently we only support to change the fulltext option when:
Big thanks to @irenjj for his previous pr #4637 which helps a lot.
Checklist