-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: consolidate DatanodeClientOptions
#4966
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
a3574d7
to
981b3c0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4966 +/- ##
==========================================
- Coverage 84.15% 83.82% -0.33%
==========================================
Files 1141 1144 +3
Lines 211063 213143 +2080
==========================================
+ Hits 177616 178674 +1058
- Misses 33447 34469 +1022 |
DatanodeClientOptions
DatanodeClientOptions
981b3c0
to
0c7b853
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM, thanks!❤️
DatanodeClientOptions
DatanodeClientOptions
0c7b853
to
9d23344
Compare
@linyihai Thanks! ❤️ |
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
Fixes #4932
What's changed and what's your intention?
Please explain IN DETAIL what the changes are in this PR and why they are needed:
DatanodeClientOptions
intocommon/options
crate.Checklist