Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: consolidate DatanodeClientOptions #4966

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

linyihai
Copy link
Contributor

@linyihai linyihai commented Nov 10, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

Fixes #4932

What's changed and what's your intention?

Please explain IN DETAIL what the changes are in this PR and why they are needed:

  • Unify the datanode options in frontend and metasrv
  • Move the DatanodeClientOptions into common/options crate.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

Copy link
Contributor

coderabbitai bot commented Nov 10, 2024

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Nov 10, 2024
@linyihai linyihai force-pushed the datanode-options branch 2 times, most recently from a3574d7 to 981b3c0 Compare November 10, 2024 06:11
Copy link

codecov bot commented Nov 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.82%. Comparing base (ac387bd) to head (9d23344).
Report is 17 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4966      +/-   ##
==========================================
- Coverage   84.15%   83.82%   -0.33%     
==========================================
  Files        1141     1144       +3     
  Lines      211063   213143    +2080     
==========================================
+ Hits       177616   178674    +1058     
- Misses      33447    34469    +1022     

@WenyXu WenyXu changed the title refactor: consolidate DatanodeClientOptions refactor!: consolidate DatanodeClientOptions Nov 11, 2024
@github-actions github-actions bot added the breaking-change This pull request contains breaking changes. label Nov 11, 2024
src/meta-srv/Cargo.toml Outdated Show resolved Hide resolved
src/datanode/src/config.rs Outdated Show resolved Hide resolved
src/cmd/tests/load_config_test.rs Show resolved Hide resolved
Copy link
Member

@WenyXu WenyXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM, thanks!❤️

src/common/options/src/datanode.rs Outdated Show resolved Hide resolved
@WenyXu WenyXu changed the title refactor!: consolidate DatanodeClientOptions refactor: consolidate DatanodeClientOptions Nov 12, 2024
@WenyXu WenyXu removed the breaking-change This pull request contains breaking changes. label Nov 12, 2024
@WenyXu
Copy link
Member

WenyXu commented Nov 12, 2024

@linyihai Thanks! ❤️

@WenyXu WenyXu added this pull request to the merge queue Nov 12, 2024
Merged via the queue into GreptimeTeam:main with commit 0b6d78a Nov 12, 2024
34 of 35 checks passed
@linyihai linyihai deleted the datanode-options branch November 12, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unify the datanode options in frontend and metasrv
3 participants