-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: unify mysql execute through cli and protocol #5038
refactor: unify mysql execute through cli and protocol #5038
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5038 +/- ##
==========================================
- Coverage 84.00% 83.76% -0.24%
==========================================
Files 1152 1154 +2
Lines 215247 215540 +293
==========================================
- Hits 180816 180550 -266
- Misses 34431 34990 +559
|
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
Refactor to simplify the
EXECUTE
stmt in mysql.Will introduce a change of error code returned: execute non-prepared stmt will now return an
ErrorKind::ER_WRONG_ARGUMENTS
instead ofErrorKind::ER_UNKNOWN_STMT_HANDLER
.Also fix a bug when the stmt is not properly prepared and we need to use raw query with param converted to strings. Previously the param of
Date
time will be converted to strings without quoteSELECT 2000-12-20
that is not valid for sql parser.Checklist