-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: adds sqlness test for TTL #5063
test: adds sqlness test for TTL #5063
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
8cadb10
to
81f5519
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5063 +/- ##
==========================================
- Coverage 84.03% 83.79% -0.25%
==========================================
Files 1158 1158
Lines 216564 216564
==========================================
- Hits 181990 181470 -520
- Misses 34574 35094 +520 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added sqlness test is very useful, and the result LGTM, thank you. Maybe we can add an additional case with combination of database ttl and metric engine reopen.
@WenyXu Looks like schema cache is missing in greptimedb/src/cache/src/lib.rs Line 43 in 24612f6
|
We need more rigorous code reviews. |
Let me fix that. |
There are two levels of cache: the upper-level cache, |
Waits for #5067 |
845ccfe
to
62c985e
Compare
@fengjiachun @waynexia PTAL |
@discord9 here adds lots of new cases for TTL. We can add those special cases like |
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
Close #5045
What's changed and what's your intention?
Adds sqlness tests for TTL behavior including normal table, metric engine table, and database TTL.
Checklist