-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable compression for metasrv client #5078
feat: enable compression for metasrv client #5078
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5078 +/- ##
==========================================
- Coverage 84.02% 83.78% -0.24%
==========================================
Files 1156 1157 +1
Lines 216301 216415 +114
==========================================
- Hits 181741 181333 -408
- Misses 34560 35082 +522 |
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
Currently, compression is not enabled for MetaSrv RPCs, which can result in errors like:
Error, message length too large: found 4228291 bytes, the limit is: 4194304 bytes
.This PR enables zstd compression for the MetaSrv client by default. We retain the default max_recv_message_size of 4 MiB, as it is a reasonable limit. Increasing it could unnecessarily burden the internal connections between cluster nodes.
Checklist