feat: ttl=0/instant/forever/humantime&ttl refactor

[discord9]

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

support ttl='instant'/'forever'

Please explain IN DETAIL what the changes are in this PR and why they are needed:

• support ttl='instant'/'forever', however to keep compatibilty, ttl='0s'/'null'/'' still equals to ttl='forever'
• refactor ttl to enum
• refactor table/database ttl, so that once table ttl is set, it can't be override by database, only after unset table ttl can database ttl be applied on a table
• add more sqlness tests for alter ttl

Checklist

• I have written the necessary rustdoc comments.
• I have added the necessary unit tests and integration tests.
• This PR requires documentation updates.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

Copilot reviewed 8 out of 23 changed files in this pull request and generated no suggestions.

Files not reviewed (15)

• src/mito2/src/engine/alter_test.rs: Evaluated as low risk
• src/mito2/src/compaction/window.rs: Evaluated as low risk
• src/mito2/src/worker/handle_alter.rs: Evaluated as low risk
• src/mito2/src/compaction/compactor.rs: Evaluated as low risk
• src/common/base/src/lib.rs: Evaluated as low risk
• src/metric-engine/src/engine/alter.rs: Evaluated as low risk
• src/mito2/src/engine/create_test.rs: Evaluated as low risk
• src/session/Cargo.toml: Evaluated as low risk
• src/mito2/src/engine/open_test.rs: Evaluated as low risk
• src/common/meta/src/ddl/alter_database.rs: Evaluated as low risk
• src/query/src/sql/show_create_table.rs: Evaluated as low risk
• src/session/src/context.rs: Evaluated as low risk
• src/common/meta/src/rpc/ddl.rs: Evaluated as low risk
• src/mito2/src/region/options.rs: Evaluated as low risk
• src/store-api/src/region_request.rs: Evaluated as low risk

Comments skipped due to low confidence (4)

src/common/base/src/ttl.rs:83

• [nitpick] The Display implementation for Duration should use a more standard format like {}s instead of Duration({}).

TimeToLive::Duration(d) => write!(f, "Duration({})", d.as_secs()),

src/common/base/src/ttl.rs:109

• The as_repr_opt method should return "forever" for the Forever variant instead of None.

TimeToLive::Forever => None,

src/common/meta/src/key/schema_name.rs:65

• [nitpick] The variable name ttl is ambiguous. It should be renamed to something more descriptive, like time_to_live.

if let Some(ttl) = self.ttl.as_repr_opt() {

src/operator/src/insert.rs:427

• Ensure that the new functionality for handling TTL zero regions and tables is covered by tests.

let ttl_zero_regions = ctx.ttl_zero_regions();

[codecov]

Codecov Report

Attention: Patch coverage is 86.98225% with 44 lines in your changes missing coverage. Please review.

Project coverage is 83.79%. Comparing base (ff4c153) to head (020ed3a).
Report is 11 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5089      +/-   ##
==========================================
- Coverage   84.04%   83.79%   -0.25%     
==========================================
  Files        1158     1163       +5     
  Lines      216564   216946     +382     
==========================================
- Hits       182003   181794     -209     
- Misses      34561    35152     +591     

[killme2008]

Use instant instead of immediate for brevity and clarity. What do you think? @discord9

[discord9]

Use instant instead of immediate for brevity and clarity. What do you think? @discord9

How about imme or now? instant also seems a bit long

[discord9]

added a fix for alter ttl to instant should remove expired ssts too

[evenyag]

Others LGTM. Most comments are non-blocking.

[evenyag]

Don't forget to update the PR title and description.

[killme2008]

LGTM

[discord9]

should SET DATABASE 'ttl'='instant' be forbidden? Or should on insert also check database ttl?

[killme2008]

should SET DATABASE 'ttl'='instant' be forbidden? Or should on insert also check database ttl?

Let's prohibit the database from setting TTL to instant, as it is illogical.