-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add cursor statements #5094
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5094 +/- ##
==========================================
- Coverage 84.04% 83.81% -0.23%
==========================================
Files 1157 1166 +9
Lines 216477 217098 +621
==========================================
+ Hits 181944 181968 +24
- Misses 34533 35130 +597 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
This patch is to address #5077
What's changed and what's your intention?
In this patch, I added initial support for postgres cursor related statements:
DECLARE $cursor CURSOR FOR $query
FETCH $size FROM $cursor
CLOSE $cursor
This patch, together with #5081 , will hopefully enable us as a postgresql foreign data wrapper compatible server.
Some utility functions are added to recordbatch module, allows to slice and merge recordbatch(es).
Tests to be added.Checklist