-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix aws_lc not in depend tree check in CI #5121
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
I have a CI task to check dependency tree: Just add |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5121 +/- ##
==========================================
- Coverage 84.04% 83.80% -0.25%
==========================================
Files 1168 1168
Lines 217620 217625 +5
==========================================
- Hits 182896 182373 -523
- Misses 34724 35252 +528 |
@discord9 remember to resolve the conflict |
311bbeb
to
67ffabc
Compare
* chore: fix aws_lc check in CI * chore: update lock file
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
make sure
aws-lc-sys
doesn't compile need to runcargo tree -i aws-lc-sys -e features --target all
, but previous it's onlycargo tree -i aws-lc-sys -e features
(missing the--target all
part), fixed that and remove a unused aws-lc-sys depend on Windowsedited: add to blacklist instead
Checklist