-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduce SKIPPING index (part 1) #5155
Conversation
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Copilot
AI
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 14 changed files in this pull request and generated 1 comment.
Files not reviewed (9)
- tests/cases/standalone/common/create/create_with_skip_index.result: Language not supported
- tests/cases/standalone/common/create/create_with_skip_index.sql: Language not supported
- src/api/src/v1/column_def.rs: Evaluated as low risk
- src/datatypes/src/error.rs: Evaluated as low risk
- src/sql/src/parsers/utils.rs: Evaluated as low risk
- src/sql/src/statements.rs: Evaluated as low risk
- src/sql/src/statements/create.rs: Evaluated as low risk
- src/operator/src/statement/ddl.rs: Evaluated as low risk
- src/datatypes/src/schema.rs: Evaluated as low risk
Comments suppressed due to low confidence (2)
src/sql/src/error.rs:329
- The error message string should be 'Failed to set skip index option' instead of 'Failed to set skip inde options'.
snafu(display("Failed to set skip index option"))
src/sql/src/error.rs:329
- [nitpick] The error message for 'SetSkipIndexOption' is not very descriptive. Consider including the specific reason for the failure.
snafu(display("Failed to set skip index option"))
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5155 +/- ##
==========================================
- Coverage 84.01% 83.79% -0.22%
==========================================
Files 1172 1173 +1
Lines 218236 218777 +541
==========================================
- Hits 183356 183333 -23
- Misses 34880 35444 +564 |
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Part 2 #5176 |
* skip index parser Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * wip: sqlness Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * impl show create part Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * add empty line Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * change keyword to SKIPPING INDEX Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * rename local variables Signed-off-by: Ruihang Xia <waynestxia@gmail.com> --------- Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia waynestxia@gmail.comI hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
Frontend(SQL) part of the new index type SKIPPING index.
Example:
Checklist