Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce SKIPPING index (part 1) #5155

Merged
merged 6 commits into from
Dec 16, 2024

Conversation

waynexia
Copy link
Member

@waynexia waynexia commented Dec 13, 2024

Signed-off-by: Ruihang Xia waynestxia@gmail.comI hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Frontend(SQL) part of the new index type SKIPPING index.

Example:

create table
    skipping_table (
        ts timestamp time index,
        id string skipping index,
        `name` string skipping index
        with
            (granularity = 8192),
    );

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
@waynexia waynexia requested review from zhongzc and Copilot December 13, 2024 07:51
@waynexia waynexia requested review from evenyag and a team as code owners December 13, 2024 07:51
Copy link
Contributor

coderabbitai bot commented Dec 13, 2024

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 14 changed files in this pull request and generated 1 comment.

Files not reviewed (9)
  • tests/cases/standalone/common/create/create_with_skip_index.result: Language not supported
  • tests/cases/standalone/common/create/create_with_skip_index.sql: Language not supported
  • src/api/src/v1/column_def.rs: Evaluated as low risk
  • src/datatypes/src/error.rs: Evaluated as low risk
  • src/sql/src/parsers/utils.rs: Evaluated as low risk
  • src/sql/src/statements.rs: Evaluated as low risk
  • src/sql/src/statements/create.rs: Evaluated as low risk
  • src/operator/src/statement/ddl.rs: Evaluated as low risk
  • src/datatypes/src/schema.rs: Evaluated as low risk
Comments suppressed due to low confidence (2)

src/sql/src/error.rs:329

  • The error message string should be 'Failed to set skip index option' instead of 'Failed to set skip inde options'.
snafu(display("Failed to set skip index option"))

src/sql/src/error.rs:329

  • [nitpick] The error message for 'SetSkipIndexOption' is not very descriptive. Consider including the specific reason for the failure.
snafu(display("Failed to set skip index option"))

src/query/src/error.rs Outdated Show resolved Hide resolved
@github-actions github-actions bot added docs-not-required This change does not impact docs. and removed docs-required This change requires docs update. labels Dec 13, 2024
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 69.47368% with 58 lines in your changes missing coverage. Please review.

Project coverage is 83.79%. Comparing base (e8e9526) to head (2aa0d3b).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5155      +/-   ##
==========================================
- Coverage   84.01%   83.79%   -0.22%     
==========================================
  Files        1172     1173       +1     
  Lines      218236   218777     +541     
==========================================
- Hits       183356   183333      -23     
- Misses      34880    35444     +564     

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Copy link
Contributor

@zhongzc zhongzc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waynexia waynexia changed the title feat: introduce SKIP index (part 1) feat: introduce SKIPPING index (part 1) Dec 16, 2024
@github-actions github-actions bot added docs-not-required This change does not impact docs. docs-required This change requires docs update. and removed docs-not-required This change does not impact docs. labels Dec 16, 2024
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
src/sql/src/parsers/utils.rs Outdated Show resolved Hide resolved
src/sql/src/parsers/create_parser.rs Outdated Show resolved Hide resolved
@waynexia waynexia enabled auto-merge December 16, 2024 09:11
@waynexia waynexia added this pull request to the merge queue Dec 16, 2024
Merged via the queue into GreptimeTeam:main with commit 5469832 Dec 16, 2024
36 checks passed
@waynexia waynexia deleted the skip-index branch December 16, 2024 09:38
@waynexia
Copy link
Member Author

Part 2 #5176

evenyag pushed a commit that referenced this pull request Dec 20, 2024
* skip index parser

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>

* wip: sqlness

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>

* impl show create part

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>

* add empty line

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>

* change keyword to SKIPPING INDEX

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>

* rename local variables

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>

---------

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs. docs-required This change requires docs update.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants