feat: introduce Buffer for non-continuous bytes #5164

CookiePieWw · 2024-12-13T17:21:12Z

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

As title. The implementation is copied from opendal actually.

Also refactor the inverted index cache to avoid a copy when reading bytes from remote blob. But we still need to copy the bytes to a continuous Vec<u8> for reading it, maybe we can avoid it by using Buffer more heavily. But Buffer itself is cache-unfriendly, so I'm not sure if it's good.

Seems Bytes it self is a thread-safe and copy-efficient, so we don't need wrap it up with an Arc.

Checklist

I have written the necessary rustdoc comments.
I have added the necessary unit tests and integration tests.
This PR requires documentation updates.

coderabbitai · 2024-12-13T17:21:19Z

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

codecov · 2024-12-13T17:37:07Z

Codecov Report

Attention: Patch coverage is 85.71429% with 4 lines in your changes missing coverage. Please review.

Project coverage is 83.80%. Comparing base (579059d) to head (fd058d4).
Report is 16 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5164      +/-   ##
==========================================
- Coverage   84.05%   83.80%   -0.25%     
==========================================
  Files        1172     1175       +3     
  Lines      218490   218960     +470     
==========================================
- Hits       183641   183499     -142     
- Misses      34849    35461     +612

src/mito2/src/cache/index.rs

Co-authored-by: Weny Xu <wenymedia@gmail.com>

src/mito2/src/cache/index.rs

WenyXu

Rest LGTM, remember to remove unnecessary TODO comments

src/mito2/src/cache/index.rs

v0y4g3r · 2024-12-17T08:35:26Z

We don't have to copy the buffer code from opendal in that we've already re-exported that struct:

greptimedb/src/object-store/src/lib.rs

Line 17 in 03a2832

    
           services, Buffer, Builder as ObjectStoreBuilder, Entry, EntryMode, Error, ErrorKind,

* feat: introduce Buffer for non-continuous bytes * Update src/mito2/src/cache/index.rs Co-authored-by: Weny Xu <wenymedia@gmail.com> * chore: apply review comments * refactor: use opendal::Buffer --------- Co-authored-by: Weny Xu <wenymedia@gmail.com>

feat: introduce Buffer for non-continuous bytes

8575331

CookiePieWw requested review from evenyag, v0y4g3r, waynexia, zhongzc and a team as code owners December 13, 2024 17:21

github-actions bot added the docs-not-required This change does not impact docs. label Dec 13, 2024

WenyXu approved these changes Dec 17, 2024

View reviewed changes

src/mito2/src/cache/index.rs Outdated Show resolved Hide resolved

Update src/mito2/src/cache/index.rs

c5b72fd

Co-authored-by: Weny Xu <wenymedia@gmail.com>

WenyXu reviewed Dec 17, 2024

View reviewed changes

src/mito2/src/cache/index.rs Outdated Show resolved Hide resolved

WenyXu reviewed Dec 17, 2024

View reviewed changes

src/mito2/src/cache/index.rs Outdated Show resolved Hide resolved

chore: apply review comments

5000f47

zhongzc approved these changes Dec 17, 2024

View reviewed changes

refactor: use opendal::Buffer

fd058d4

v0y4g3r enabled auto-merge December 18, 2024 03:44

v0y4g3r added this pull request to the merge queue Dec 18, 2024

Merged via the queue into GreptimeTeam:main with commit 7d1bcc9 Dec 18, 2024
36 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: introduce Buffer for non-continuous bytes #5164

feat: introduce Buffer for non-continuous bytes #5164

CookiePieWw commented Dec 13, 2024 •

edited

Loading

coderabbitai bot commented Dec 13, 2024 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

codecov bot commented Dec 13, 2024 •

edited

Loading

WenyXu left a comment

v0y4g3r commented Dec 17, 2024

feat: introduce Buffer for non-continuous bytes #5164

feat: introduce Buffer for non-continuous bytes #5164

Conversation

CookiePieWw commented Dec 13, 2024 • edited Loading

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Checklist

coderabbitai bot commented Dec 13, 2024 • edited Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

codecov bot commented Dec 13, 2024 • edited Loading

Codecov Report

WenyXu left a comment

Choose a reason for hiding this comment

v0y4g3r commented Dec 17, 2024

CookiePieWw commented Dec 13, 2024 •

edited

Loading

coderabbitai bot commented Dec 13, 2024 •

edited

Loading

codecov bot commented Dec 13, 2024 •

edited

Loading