Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: implement a CacheStrategy to ensure compaction use cache correctly #5254

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

evenyag
Copy link
Contributor

@evenyag evenyag commented Dec 28, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

Some changes revert #5135

What's changed and what's your intention?

This PR implements a CompactionStrategy to replace Option<CacheManagerRef> so we can control how compaction uses caches.

  • For queries, the strategy forwards all operations to the cache manager.
  • The strategy only uses the write cache and the metadata cache for compactions.
  • The Disabled strategy means disable all caches.

PR Checklist

Please convert it to a draft if some of the following conditions are not met.

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.
  • API changes are backward compatible.
  • Schema or data changes are backward compatible.

Copy link
Contributor

coderabbitai bot commented Dec 28, 2024

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Dec 28, 2024
@evenyag evenyag marked this pull request as ready for review December 28, 2024 15:28
@evenyag evenyag requested review from v0y4g3r, waynexia and a team as code owners December 28, 2024 15:28
@evenyag evenyag added C-performance Category Performance A-storage Involves code in storage engines labels Dec 28, 2024
@evenyag evenyag requested a review from shuiyisong December 28, 2024 15:37
src/mito2/src/cache.rs Outdated Show resolved Hide resolved
Copy link

codecov bot commented Dec 28, 2024

Codecov Report

Attention: Patch coverage is 84.57944% with 33 lines in your changes missing coverage. Please review.

Project coverage is 83.69%. Comparing base (11bab0c) to head (3da6aa5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5254      +/-   ##
==========================================
- Coverage   83.93%   83.69%   -0.24%     
==========================================
  Files        1203     1203              
  Lines      224150   224241      +91     
==========================================
- Hits       188141   187685     -456     
- Misses      36009    36556     +547     

@evenyag evenyag force-pushed the fix/compaction-write-cache branch from 120c4f6 to 3da6aa5 Compare December 29, 2024 05:05
@evenyag
Copy link
Contributor Author

evenyag commented Dec 29, 2024

https://github.com/GreptimeTeam/greptimedb/actions/runs/12532626343/job/34951585899?pr=5254

I don't know why all runners already installed fuzz and gc-bin......

warning: tool `rust-analyzer` is already installed, remove it from `/home/runner/.cargo/bin`, then run `rustup update` to have rustup manage this tool.
warning: tool `rustfmt` is already installed, remove it from `/home/runner/.cargo/bin`, then run `rustup update` to have rustup manage this tool.
warning: tool `cargo-fmt` is already installed, remove it from `/home/runner/.cargo/bin`, then run `rustup update` to have rustup manage this tool.
    Updating crates.io index
 Downloading crates ...
  Downloaded cargo-fuzz v0.12.0
error: binary `cargo-fuzz` already exists in destination
Add --force to overwrite
    Updating crates.io index
 Downloading crates ...
  Downloaded cargo-gc-bin v0.1.4
error: binary `cargo-gc` already exists in destination
Add --force to overwrite
     Summary Failed to install cargo-fuzz, cargo-gc-bin (see error(s) above).
error: some crates failed to install

Now I add --force to all install commands

@evenyag evenyag requested a review from waynexia December 29, 2024 05:25
Copy link
Contributor

@v0y4g3r v0y4g3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

src/mito2/src/read/scan_region.rs Outdated Show resolved Hide resolved
@evenyag evenyag requested a review from v0y4g3r December 29, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-storage Involves code in storage engines C-performance Category Performance docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants