-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: implement a CacheStrategy to ensure compaction use cache correctly #5254
base: main
Are you sure you want to change the base?
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5254 +/- ##
==========================================
- Coverage 83.93% 83.69% -0.24%
==========================================
Files 1203 1203
Lines 224150 224241 +91
==========================================
- Hits 188141 187685 -456
- Misses 36009 36556 +547 |
120c4f6
to
3da6aa5
Compare
https://github.com/GreptimeTeam/greptimedb/actions/runs/12532626343/job/34951585899?pr=5254 I don't know why all runners already installed fuzz and gc-bin......
Now I add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
Some changes revert #5135
What's changed and what's your intention?
This PR implements a
CompactionStrategy
to replaceOption<CacheManagerRef>
so we can control how compaction uses caches.Disabled
strategy means disable all caches.PR Checklist
Please convert it to a draft if some of the following conditions are not met.