Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: task list syntax error in pull_request_template #528

Merged
merged 1 commit into from
Nov 15, 2022
Merged

fix: task list syntax error in pull_request_template #528

merged 1 commit into from
Nov 15, 2022

Conversation

xtang
Copy link
Contributor

@xtang xtang commented Nov 15, 2022

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

  • task list syntax in markdown has a leading dash

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

#523

@xtang xtang requested review from killme2008 and waynexia November 15, 2022 15:33
killme2008
killme2008 approved these changes Nov 15, 2022
View reviewed changes
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

waynexia
waynexia approved these changes Nov 15, 2022
View reviewed changes
Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These checkboxs will be counted as task in PR list page. I'm not sure whether this is annoying. Anyway let's try it for a while

@killme2008 killme2008 merged commit e823cde into develop Nov 15, 2022
@killme2008 killme2008 deleted the fix/task-syntax-error branch November 15, 2022 15:53
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
@xtang @paomian
fix: task list syntax error in pull_request_template (GreptimeTeam#528
2a46692 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waynexia waynexia waynexia approved these changes

@killme2008 killme2008 killme2008 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xtang @killme2008 @waynexia