Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remote issue title prefix from template #533

Merged
merged 2 commits into from
Nov 16, 2022
Merged

Conversation

waynexia
Copy link
Member

Signed-off-by: Ruihang Xia waynestxia@gmail.com

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Remove title prefix (like [Enhancement] or [Bug]) as they are included in lables.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
@waynexia waynexia requested review from xtang and evenyag November 16, 2022 07:26
Copy link
Contributor

@xtang xtang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Nov 16, 2022

Codecov Report

Merging #533 (68d0c6d) into develop (872ac80) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 68d0c6d differs from pull request most recent head 26b5f04. Consider uploading reports for the commit 26b5f04 to get more accurate results

@@           Coverage Diff            @@
##           develop     #533   +/-   ##
========================================
  Coverage    86.39%   86.40%           
========================================
  Files          398      398           
  Lines        50008    50008           
========================================
+ Hits         43204    43208    +4     
+ Misses        6804     6800    -4     
Flag Coverage Δ
rust 86.40% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/meta-srv/src/service/heartbeat.rs 86.31% <0.00%> (-1.06%) ⬇️
src/servers/src/mysql/writer.rs 75.21% <0.00%> (-0.86%) ⬇️
src/log-store/src/fs/file.rs 88.72% <0.00%> (-0.17%) ⬇️
src/servers/src/opentsdb.rs 98.41% <0.00%> (+1.58%) ⬆️
src/servers/src/error.rs 43.24% <0.00%> (+16.21%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@waynexia waynexia merged commit 5979dcf into develop Nov 16, 2022
@waynexia waynexia deleted the remote-title-prefix branch November 16, 2022 07:46
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
* chore: remote issue title prefix from template

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>

* change feature request's label name

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants