Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Rename table-engine to mito #539

Merged
merged 4 commits into from
Nov 16, 2022

Conversation

evenyag
Copy link
Contributor

@evenyag evenyag commented Nov 16, 2022

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

This PR renames the table-engine crate to mito.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@evenyag evenyag marked this pull request as ready for review November 16, 2022 08:52
@codecov
Copy link

codecov bot commented Nov 16, 2022

Codecov Report

Merging #539 (56e6901) into develop (5979dcf) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 56e6901 differs from pull request most recent head 4d722f5. Consider uploading reports for the commit 4d722f5 to get more accurate results

@@           Coverage Diff            @@
##           develop     #539   +/-   ##
========================================
  Coverage    86.38%   86.39%           
========================================
  Files          398      398           
  Lines        50008    50008           
========================================
+ Hits         43201    43202    +1     
+ Misses        6807     6806    -1     
Flag Coverage Δ
rust 86.39% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/catalog/src/system.rs 90.00% <ø> (ø)
src/datanode/src/instance.rs 36.15% <ø> (ø)
src/datanode/src/mock.rs 99.11% <ø> (ø)
src/datanode/src/sql.rs 74.49% <ø> (ø)
src/mito/src/config.rs 100.00% <ø> (ø)
src/mito/src/engine.rs 97.35% <ø> (ø)
src/mito/src/error.rs 80.00% <ø> (ø)
src/mito/src/lib.rs 100.00% <ø> (ø)
src/mito/src/manifest.rs 95.55% <ø> (ø)
src/mito/src/manifest/action.rs 95.95% <ø> (ø)
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/mito/README.md Show resolved Hide resolved
@evenyag evenyag force-pushed the refactor/rename-table-engine branch from 79bd224 to 56e6901 Compare November 16, 2022 09:45
@evenyag evenyag force-pushed the refactor/rename-table-engine branch from 56e6901 to 08a8ef8 Compare November 16, 2022 10:11
@evenyag evenyag force-pushed the refactor/rename-table-engine branch from 08a8ef8 to 4d722f5 Compare November 16, 2022 10:16
@waynexia waynexia merged commit 55f18b5 into GreptimeTeam:develop Nov 16, 2022
@evenyag evenyag deleted the refactor/rename-table-engine branch November 16, 2022 10:24
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
* refactor: Rename table-engine to mito

* style: Format codes

* docs: Update mito engine comment

* docs: Explain what is mito in README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants