Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: split code and output in README #549

Merged
merged 1 commit into from
Nov 17, 2022

Conversation

killme2008
Copy link
Contributor

@killme2008 killme2008 commented Nov 16, 2022

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Split the SQL and its output in README. So the user can copy the SQL and run it directly.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@killme2008 killme2008 marked this pull request as ready for review November 16, 2022 16:40
@killme2008 killme2008 requested review from sunng87 and xtang November 16, 2022 16:41
Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evenyag evenyag merged commit 73e6e2e into GreptimeTeam:develop Nov 17, 2022
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
@killme2008 killme2008 deleted the fix/readme-code-block branch January 16, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants