-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement table_info()
for DistTable
(#536)
#557
feat: Implement table_info()
for DistTable
(#536)
#557
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #557 +/- ##
========================================
Coverage 86.38% 86.39%
========================================
Files 398 398
Lines 50042 50116 +74
========================================
+ Hits 43229 43297 +68
- Misses 6813 6819 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Yingwen <1405012107@qq.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…eptimeTeam#557) * feat: Implement `table_info()`` for `DistTable` (GreptimeTeam#536) * Update src/catalog/src/error.rs Co-authored-by: Yingwen <1405012107@qq.com> Co-authored-by: luofucong <luofucong@greptime.com> Co-authored-by: Yingwen <1405012107@qq.com>
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
close #536
Please explain IN DETAIL what the changes are in this PR and why they are needed:
Implement
table_info()
forDistTable
. Originallyunimplemented!()
.Store
TableInfo
inTableGlobalValue
, which is later stored in Meta for retrieval.Checklist
Refer to a related PR or issue link (optional)
#536