Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement table_info() for DistTable (#536) #557

Merged
merged 2 commits into from
Nov 17, 2022

Conversation

MichaelScofield
Copy link
Collaborator

@MichaelScofield MichaelScofield commented Nov 17, 2022

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

close #536

Please explain IN DETAIL what the changes are in this PR and why they are needed:

  • Summarize your change (mandatory)

Implement table_info() for DistTable. Originally unimplemented!().

  • How does this PR work? Need a brief introduction for the changed logic (optional)

Store TableInfo in TableGlobalValue, which is later stored in Meta for retrieval.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

#536

@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Merging #557 (07cbd78) into develop (8faa6b0) will increase coverage by 0.00%.
The diff coverage is 68.93%.

@@           Coverage Diff            @@
##           develop     #557   +/-   ##
========================================
  Coverage    86.38%   86.39%           
========================================
  Files          398      398           
  Lines        50042    50116   +74     
========================================
+ Hits         43229    43297   +68     
- Misses        6813     6819    +6     
Flag Coverage Δ
rust 86.39% <68.93%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/catalog/src/error.rs 84.21% <0.00%> (ø)
src/catalog/src/remote/manager.rs 70.51% <0.00%> (-0.24%) ⬇️
src/frontend/src/catalog.rs 6.86% <0.00%> (+0.03%) ⬆️
src/frontend/src/table.rs 91.72% <73.58%> (-1.07%) ⬇️
src/common/catalog/src/helper.rs 85.78% <100.00%> (+1.17%) ⬆️
src/frontend/src/instance/distributed.rs 84.49% <100.00%> (+0.58%) ⬆️
src/meta-srv/src/service/router.rs 91.62% <100.00%> (-0.05%) ⬇️
src/servers/src/mysql/writer.rs 75.21% <0.00%> (ø)
src/servers/src/opentsdb/handler.rs 94.89% <0.00%> (+1.02%) ⬆️
src/servers/src/opentsdb.rs 98.41% <0.00%> (+1.58%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@v0y4g3r v0y4g3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/catalog/src/error.rs Outdated Show resolved Hide resolved
Co-authored-by: Yingwen <1405012107@qq.com>
Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@killme2008 killme2008 merged commit e7b4d2b into GreptimeTeam:develop Nov 17, 2022
@MichaelScofield MichaelScofield deleted the feat/dist-table-info branch November 17, 2022 10:47
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
…eptimeTeam#557)

* feat: Implement `table_info()`` for `DistTable` (GreptimeTeam#536)

* Update src/catalog/src/error.rs

Co-authored-by: Yingwen <1405012107@qq.com>

Co-authored-by: luofucong <luofucong@greptime.com>
Co-authored-by: Yingwen <1405012107@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement table_info() for DistTable
4 participants