-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: drop column for alter table #562
feat: drop column for alter table #562
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #562 +/- ##
===========================================
- Coverage 86.38% 86.35% -0.04%
===========================================
Files 398 398
Lines 50042 50165 +123
===========================================
+ Hits 43229 43320 +91
- Misses 6813 6845 +32
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
520911e
to
addb5ae
Compare
Co-authored-by: Ruihang Xia <waynestxia@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* feat: drop column for alter table * refactor: rename RemoveColumns to DropColumns * test: alter table * chore: error msg Co-authored-by: Ruihang Xia <waynestxia@gmail.com> * fix: test_parse_alter_drop_column Co-authored-by: Ruihang Xia <waynestxia@gmail.com>
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Try to fix #466, which supports
alter table drop column [name]
:Checklist
Refer to a related PR or issue link (optional)