Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add nightly build job #565

Merged
merged 1 commit into from
Nov 18, 2022
Merged

Conversation

zyy17
Copy link
Collaborator

@zyy17 zyy17 commented Nov 18, 2022

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Add GitHub nightly build. The GitHub Action will be scheduled at 00:00 everyday to build the develop branch and release artifacts for using tag 0.1.0-alpha-<YYYYMMDD>-nightly.

Please explain IN DETAIL what the changes are in this PR and why they are needed:

  • Summarize your change (mandatory)
    Modify the release.yaml:

    • Add GitHub Action cron;
    • Using the different formats of the tag for different trigger event('scheduled' or normal release);
  • How does this PR work? Need a brief introduction for the changed logic (optional)

  • Describe clearly one logical change and avoid lazy messages (optional)

  • Describe any limitations of the current code (optional)

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Merging #565 (7d4ca55) into develop (f878827) will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #565      +/-   ##
===========================================
+ Coverage    86.35%   86.37%   +0.01%     
===========================================
  Files          398      398              
  Lines        50165    50165              
===========================================
+ Hits         43322    43328       +6     
+ Misses        6843     6837       -6     
Flag Coverage Δ
rust 86.37% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/storage/src/region/tests.rs 95.63% <0.00%> (-0.49%) ⬇️
src/servers/src/opentsdb.rs 98.41% <0.00%> (+1.58%) ⬆️
src/servers/src/error.rs 43.24% <0.00%> (+16.21%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I heard github action's crontab has a very heavy delay, let's see how it goes here 🤣

@waynexia waynexia changed the title ci: add nightly build ci: add nightly build job Nov 18, 2022
@waynexia waynexia merged commit dee5cce into GreptimeTeam:develop Nov 18, 2022
@zyy17 zyy17 deleted the ci/add-nightly-build branch November 18, 2022 06:16
@zyy17
Copy link
Collaborator Author

zyy17 commented Nov 18, 2022

@waynexia I test in my private repo and the result looks acceptable. We don't need the precise schedule.

paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants