-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update mysql default listen port to 4406 #568
Conversation
@waynexia please review it for me, thanks. |
Codecov Report
@@ Coverage Diff @@
## develop #568 +/- ##
===========================================
- Coverage 86.35% 86.35% -0.01%
===========================================
Files 398 398
Lines 50165 50165
===========================================
- Hits 43322 43321 -1
- Misses 6843 6844 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
It should be better to modify the default mysql port in datanode.rs. |
I have a question, what's the difference between |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: zhaozhenhang <zhaozhenhang@kuaishou.com>
Signed-off-by: azhmesoso zzhncut123@163.com
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Right now the datanode listens on 127.0.0.1:3306 for MySQL connections, it may conflict with the user's MySQL server, so I should change this default address to 127.0.0.1:4406.
Please explain IN DETAIL what the changes are in this PR and why they are needed:
updata mysql default listen port to 4406.
Checklist
Refer to a related PR or issue link (optional)