Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update mysql default listen port to 4406 #568

Merged
merged 3 commits into from
Nov 18, 2022
Merged

feat: update mysql default listen port to 4406 #568

merged 3 commits into from
Nov 18, 2022

Conversation

azhsmesos
Copy link
Contributor

@azhsmesos azhsmesos commented Nov 18, 2022

Signed-off-by: azhmesoso zzhncut123@163.com
I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Right now the datanode listens on 127.0.0.1:3306 for MySQL connections, it may conflict with the user's MySQL server, so I should change this default address to 127.0.0.1:4406.
Please explain IN DETAIL what the changes are in this PR and why they are needed:

  • Summarize your change (mandatory)
    updata mysql default listen port to 4406.
  • How does this PR work? Need a brief introduction for the changed logic (optional)
  • Describe clearly one logical change and avoid lazy messages (optional)
  • Describe any limitations of the current code (optional)

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@azhsmesos
Copy link
Contributor Author

@waynexia please review it for me, thanks.

@evenyag evenyag changed the title feat(updatePort): update mysql default listen port to 4406 feat: update mysql default listen port to 4406 Nov 18, 2022
@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Merging #568 (594fd51) into develop (f878827) will decrease coverage by 0.00%.
The diff coverage is 66.66%.

@@             Coverage Diff             @@
##           develop     #568      +/-   ##
===========================================
- Coverage    86.35%   86.35%   -0.01%     
===========================================
  Files          398      398              
  Lines        50165    50165              
===========================================
- Hits         43322    43321       -1     
- Misses        6843     6844       +1     
Flag Coverage Δ
rust 86.35% <66.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/cmd/src/standalone.rs 37.35% <0.00%> (ø)
src/cmd/src/datanode.rs 81.69% <100.00%> (ø)
src/datanode/src/datanode.rs 52.63% <100.00%> (ø)
src/meta-srv/src/service/heartbeat.rs 86.31% <0.00%> (-1.06%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@paomian
Copy link
Contributor

paomian commented Nov 18, 2022

It should be better to modify the default mysql port in datanode.rs.
By the way, there are some test about datanode default mysql port config in datanode.example.toml

@azhsmesos
Copy link
Contributor Author

It should be better to modify the default mysql port in datanode.rs. By the way, there are some test about datanode default mysql port config in datanode.example.toml

I have a question, what's the difference between mysql_addr = '127.0.0.1:4406' and datanode_mysql_addr = '127.0.0.1:4406'

@paomian
Copy link
Contributor

paomian commented Nov 18, 2022

datanode_mysql_addr purpose is just for testing.
It's used when start in distribution mode. In the future, we will make it optional.

Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@v0y4g3r v0y4g3r self-requested a review November 18, 2022 06:54
Copy link
Contributor

@v0y4g3r v0y4g3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@v0y4g3r v0y4g3r merged commit 6d762aa into GreptimeTeam:develop Nov 18, 2022
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
Co-authored-by: zhaozhenhang <zhaozhenhang@kuaishou.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants