Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump OpenDAL to v0.20 #569

Merged
merged 1 commit into from
Nov 18, 2022
Merged

Conversation

Xuanwo
Copy link
Contributor

@Xuanwo Xuanwo commented Nov 18, 2022

Signed-off-by: Xuanwo github@xuanwo.io

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Bump OpenDAL to v0.20 for bug fixes and new features.

Read CHANGELOG for more details.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Signed-off-by: Xuanwo <github@xuanwo.io>
@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Merging #569 (00e6413) into develop (f878827) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #569   +/-   ##
========================================
  Coverage    86.35%   86.36%           
========================================
  Files          398      398           
  Lines        50165    50165           
========================================
+ Hits         43322    43323    +1     
+ Misses        6843     6842    -1     
Flag Coverage Δ
rust 86.36% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/object-store/src/lib.rs 100.00% <ø> (ø)
src/object-store/src/util.rs 100.00% <100.00%> (ø)
src/storage/src/manifest/storage.rs 98.03% <100.00%> (ø)
src/meta-srv/src/service/heartbeat.rs 86.31% <0.00%> (-1.06%) ⬇️
src/servers/src/mysql/writer.rs 75.21% <0.00%> (-0.86%) ⬇️
src/servers/src/error.rs 35.13% <0.00%> (+8.10%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution!

@evenyag evenyag requested review from v0y4g3r and waynexia November 18, 2022 05:38
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@killme2008 killme2008 merged commit 1f0b39c into GreptimeTeam:develop Nov 18, 2022
@Xuanwo Xuanwo deleted the bump-opendal branch November 18, 2022 06:18
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
Signed-off-by: Xuanwo <github@xuanwo.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants