-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correctly open table when distributed datanode restart #576
fix: correctly open table when distributed datanode restart #576
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #576 +/- ##
===========================================
- Coverage 86.45% 86.41% -0.04%
===========================================
Files 399 400 +1
Lines 50649 50675 +26
===========================================
+ Hits 43788 43793 +5
- Misses 6861 6882 +21
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@killme2008 PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job. The PR content may need to be edited too.
@killme2008 PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
1122223
to
6b686fa
Compare
@v0y4g3r PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM
…Team#576) Co-authored-by: luofucong <luofucong@greptime.com>
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
fix #402
Please explain IN DETAIL what the changes are in this PR and why they are needed:
--data-dir
and--wal-dir
to command line options, to indicate dn's data dir and wal dir in distributed mode.Checklist
Refer to a related PR or issue link (optional)