-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make nullable as default when alter table #591
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #591 +/- ##
===========================================
+ Coverage 86.45% 86.47% +0.01%
===========================================
Files 399 399
Lines 50640 50640
===========================================
+ Hits 43783 43790 +7
+ Misses 6857 6850 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for your contribution.
Could you please also add some unit tests to cover this scenario? Like asserting when the ColumnDef
will be nullable and when not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks every one. I will add tests to cover this. |
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Fix bug #364
Make nullable as default when alter table.
Please explain IN DETAIL what the changes are in this PR and why they are needed:
Make nullable as default when alter table
Checklist
Refer to a related PR or issue link (optional)