Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make nullable as default when alter table #591

Merged
merged 2 commits into from
Nov 21, 2022

Conversation

yfractal
Copy link
Contributor

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Fix bug #364
Make nullable as default when alter table.

Please explain IN DETAIL what the changes are in this PR and why they are needed:

  • Summarize your change (mandatory)
    Make nullable as default when alter table
  • How does this PR work? Need a brief introduction for the changed logic (optional)
  • Describe clearly one logical change and avoid lazy messages (optional)
  • Describe any limitations of the current code (optional)

Checklist

  • [] I have written the necessary rustdoc comments.
  • [] I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@codecov
Copy link

codecov bot commented Nov 20, 2022

Codecov Report

Merging #591 (f60bd38) into develop (f465040) will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop     #591      +/-   ##
===========================================
+ Coverage    86.45%   86.47%   +0.01%     
===========================================
  Files          399      399              
  Lines        50640    50640              
===========================================
+ Hits         43783    43790       +7     
+ Misses        6857     6850       -7     
Flag Coverage Δ
rust 86.47% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/sql/src/statements.rs 80.62% <0.00%> (ø)
src/servers/src/opentsdb.rs 98.41% <0.00%> (+1.58%) ⬆️
src/servers/src/error.rs 43.24% <0.00%> (+16.21%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for your contribution.

Could you please also add some unit tests to cover this scenario? Like asserting when the ColumnDef will be nullable and when not.

Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@killme2008 killme2008 merged commit 5428ad3 into GreptimeTeam:develop Nov 21, 2022
@yfractal
Copy link
Contributor Author

Thanks every one.

I will add tests to cover this.

@yfractal yfractal deleted the fix/sql-alter branch November 23, 2022 12:58
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants